Support mult-chain wallets in get_metadata calls #46
Conversation
|
This pull request has been linked to Shortcut Story #66190: Support new feature from Formatic Admin API in magic-admin-python SDK.. |
There was a problem hiding this comment.
Looks good to me, just one note, if this repo doesn't have pre-commit setup to run black, pylint, flake8, then we should create a ticket to track that. This is a public project so we should ideally be setup with some automation for the day someone actually submits a pull request
| from testing.data.did_token import future_did_token | ||
| from testing.data.did_token import issuer | ||
| from testing.data.did_token import public_address | ||
|
|
||
|
|
||
| class TestUser: | ||
|
|
There was a problem hiding this comment.
we don't do the extra newline at the top of classes anymore
Sounds good - ticket created https://app.shortcut.com/magic-labs/story/67008/magic-admin-python-setup-pre-commit |
justinnout
deleted the
justinherrera-sc-66190-support-new-feature-from-formatic-admin-api
branch
📦 Pull Request
The current implementation of magic-admin-php for metadata retrieval returns the Ethereum public_address.
We are adding functionality to query wallet(s) for any chain tied to the end-user.
Example (queries all Solana wallets created for the user if applicable):
meta = magic.User.get_metadata_by_token_and_wallet(did_token, WalletType.SOLANA)Example (queries all wallets created for the user if applicable):
meta = magic.User.get_metadata_by_token_and_wallet(did_token, WalletType.ANY)Please see supported wallet types in
magic_admin/resources/wallet.py.🗜 Versioning
(Check one!)
✅ Fixed Issues
🚨 Test instructions
make testCHANGELOG.mdUpcoming Changessection ofCHANGELOG.mdwith context related to this Pull Request.